Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move auth routes to /dashboard #2157

Merged
merged 5 commits into from
May 1, 2024
Merged

move auth routes to /dashboard #2157

merged 5 commits into from
May 1, 2024

Conversation

adamsoffer
Copy link
Contributor

Moved the following routes inside /dashboard so that we can run a proxy to those routes when the site moves to webflow.

https://livepeer.studio/dashboard/register
https://livepeer.studio/dashboard/login
https://livepeer.studio/dashboard/forgot-password
https://livepeer.studio/dashboard/verify
https://livepeer.studio/dashboard/verify-new-email

@adamsoffer adamsoffer requested review from a team as code owners April 30, 2024 17:57
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 4:31pm

iameli
iameli suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@iameli iameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's add redirects for the old routes on this app too, so this can be deployed incrementally prior to the Webflow change?

@adamsoffer
Copy link
Contributor Author

Maybe let's add redirects for the old routes on this app too, so this can be deployed incrementally prior to the Webflow change?

@iameli I put these in place. Are there any others I missed?

@iameli
Copy link
Contributor

iameli commented Apr 30, 2024

@adamsoffer Ah nice I missed that. Will redirects using that mechanism keep query strings in place? Because that'll be needed for email verification and stuff to work. Assuming it does, we're probably good

@adamsoffer
Copy link
Contributor Author

@adamsoffer Ah nice I missed that. Will redirects using that mechanism keep query strings in place? Because that'll be needed for email verification and stuff to work. Assuming it does, we're probably good

@iameli just made an update to the redirects to ensure query strings are still in place.

@adamsoffer adamsoffer merged commit 7d3d68c into master May 1, 2024
13 checks passed
@adamsoffer adamsoffer deleted the as/move-routes branch May 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameli iameli iameli approved these changes

@victorges victorges Awaiting requested review from victorges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsoffer @iameli